Skip to content

Conversation

@JosXa
Copy link
Contributor

@JosXa JosXa commented Jul 17, 2017

No description provided.

@JosXa JosXa requested a review from jh0ker July 17, 2017 15:34

def reply_markdown(self, *args, **kwargs):
"""
Shortcut for ``bot.sendMessage(update.message.chat_id, parse_mode=ParseMode.MARKDOWN, *args, **kwargs)``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to:

Shortcut for::

<two time indent>bot.sendMessage(update.message.chat_id, parse_mode=ParseMode.MARKDOWN, *args, **kwargs)

Shortcut for ``bot.sendMessage(update.message.chat_id, parse_mode=ParseMode.MARKDOWN, *args, **kwargs)``
Sends a message with markdown formatting.
Keyword Args:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Args: (without keyword)

Keyword Args:
quote (Optional[bool]): If set to ``True``, the message is sent as an actual reply to
this message. If ``reply_to_message_id`` is passed in ``kwargs``, this parameter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent continuing line with two indents.

Copy link
Member

@Eldinnie Eldinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some comments in the code regarding docstrings.

@Eldinnie Eldinnie self-assigned this Jul 19, 2017
@Eldinnie Eldinnie added the 📋 pending-reply work status: pending-reply label Jul 19, 2017
@rahiel
Copy link
Contributor

rahiel commented Jul 19, 2017

Could you change bot.sendMessage to bot.send_message, and bot.editMessageText to bot.edit_message_text in the docstrings? We prefer snake_case method names now.

@JosXa
Copy link
Contributor Author

JosXa commented Sep 11, 2017

Closed by #827.

@JosXa JosXa closed this Sep 11, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2020
@Bibo-Joshi Bibo-Joshi deleted the reply-text-markdown branch November 23, 2020 08:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

📋 pending-reply work status: pending-reply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants