Skip to content

docs: set minimum Sphinx version to version running at read the docs - #724

Closed
rahiel wants to merge 1 commit into
masterfrom
fix-rtd
Closed

docs: set minimum Sphinx version to version running at read the docs#724
rahiel wants to merge 1 commit into
masterfrom
fix-rtd

Conversation

@rahiel

@rahiel rahiel commented Jul 17, 2017

Copy link
Copy Markdown
Contributor

As mentioned in #684, the doc builds are failing because of the version requirement.

@rahiel rahiel added the ⚙️ documentation affected functionality: documentation label Jul 17, 2017
@jsmnbom

jsmnbom commented Jul 17, 2017

Copy link
Copy Markdown
Member

You realize there was a reason to have 1.5.4 as the min version right? Did I look at the changelogs wrong or something? (also the comment definitely needs to go if that's no longer the reason to have the min version... in fact just remove the statement completely (by commenting)...)

@Eldinnie

Copy link
Copy Markdown
Member

What's with this? Currently I'm building docs with sphinx 1.6.1 without any trouble.

@rahiel

rahiel commented Jul 19, 2017

Copy link
Copy Markdown
Contributor Author

@bomjacob yeah I wasn't thinking clearly here, closing this PR.

@Eldinnie it's about the documentation builds failing at read the docs.

@rahiel rahiel closed this Jul 19, 2017
@rahiel
rahiel deleted the fix-rtd branch July 19, 2017 09:22
@jsmnbom

jsmnbom commented Jul 19, 2017

Copy link
Copy Markdown
Member

We still need to do something so our builds work on read the docs though... @jh0ker is it possible to upload the files ourselves and then you can just build them manually on each each release (or even have travis do it!).
Edit: Oh nvm, @rahiel fixed in 729

@jh0ker

jh0ker commented Jul 19, 2017

Copy link
Copy Markdown
Member

@bomjacob Hmm not that I know

@rahiel rahiel added ¯\_(ツ)_/¯ and removed ⚙️ documentation affected functionality: documentation labels Jul 19, 2017
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants