Fix #695 by checking if a user exists - #699
Merged
Merged
Conversation
Check if a user exists for the update because it can't be used otherwise in a conversationhandler. Added a test to detect python-telegram-bot#695
Member
|
Seems good to me. Let's merge |
Eldinnie
self-requested a review
July 23, 2017 09:09
Eldinnie
approved these changes
Jul 23, 2017
Member
|
@pingiun Thankyou for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if a user exists for the update because it can't be used
otherwise in a conversationhandler.
Added a test to detect #695
Fixes #695
This PR doesn't fix #637 even though it was requested in 695 because making from_user optional would make it a keyword argument, which would break compatibility.