Allow specifying pass_* for handlers in callback annotations #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically annoatations that describe weather to pass fx. update_queue or chat_data. Only works with RegexHandler for now
jsmnbom
added a commit
that referenced
this pull request
Jun 30, 2017
- Add until_date to kick_chat_member - Add restrict_chat_member - Add promote_chat_member - Add export_chat_invite_link - Add set_chat_photo refs #679
jsmnbom
added a commit
that referenced
this pull request
Jun 30, 2017
- Add delete_chat_photo - Add set_chat_title - Add set_chat_description - Add pin_chat_message - Add unpin_chat_message refs #679
jsmnbom
added a commit
that referenced
this pull request
Jun 30, 2017
- Add until_date, can_be_edited, can_change_info, can_post_messages, can_edit_messages, can_delete_messages, can_invite_users, can_restrict_members, can_pin_messages, can_promote_members, can_send_messages, can_send_media_messages, can_send_other_messages and can_add_web_page_previews to ChatMember - Add photo, description and invite_link to Chat - Move _totimestamp and _fromtimestamp from Message to utils.helpers since it's now needed more than once place refs #679
Member
Author
|
Closing due to lack of interest (PR's shouldn't be long standing) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often find it annoying to have to declare a ton of pass_* statements in handlers. This makes it so:
and
are equal.
Following annotations work
I've changed code such that these types are actually passed to the callback methods, so typecheckers that check annotations are happy.
One more this this allows you to you is have something like:
Where the group and groupdict arguments can have other names (something that's always worked wih bot and update).