Skip to content

Conversation

@jsmnbom
Copy link
Member

@jsmnbom jsmnbom commented Jun 18, 2017

Moves a lot of files into seperate packages so it's easier to maintain.
I have a few questions:

  • Should files be renamed to media?
  • Should we give the tests directory the same treatment?
  • Should all the subpackages have a proper __init__.py file with __all__ despite not being meant for import by the user?
  • Should the subpackages have an underscore prepended since they are internal?

Closes #619

Copy link
Member

@tsnoam tsnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.
Just make sure to merge with latest master and that Travis will pass.

@Eldinnie
Copy link
Member

Eldinnie commented Jun 22, 2017

I would love it if the imports would be grouped (all games imports together) and in alphabetical order too. It's not necessary, but it's looks a lot cleaner
edit - not possible due to dependencies.

@tsnoam tsnoam merged commit 56949bc into master Jun 22, 2017
@tsnoam tsnoam deleted the restructure-internal branch June 22, 2017 18:26
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split internal code for better maintainability

4 participants