Simplification of boolean checks #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Look good, let's wait if Travis aggrees |
Member
|
It was discussed in the developer group that while this change is good, we still should enforce |
Contributor
Author
|
Will do. |
Contributor
Author
|
This should do it, I guess. Or should I add a comment for clarification? |
Member
|
Thanks, it looks good :) |
Bibo-Joshi
added
🔌 enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I worked on the other pull request, I saw that the boolean checks for the payment functions are somewhat unpythonic (See https://www.python.org/dev/peps/pep-0008/#programming-recommendations the last bullet point for reference).