-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Rename shortcut functions to snake_case #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename shortcut functions to snake_case #661
Conversation
|
I know there are a few other places... maybe if you search for "*args, **kwargs" or something you'll find them.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If Travis approves we can merge.
|
Found some more, working on it. |
|
Ok. There is more. Give me one or two days to look through the code, there are some files, I did not look at yet. |
|
Ok, I'm done. I read through all the code and will go to bed now. That should really have been it now. |
|
@saschalalala Good night :) |
|
Okay, some tests fail because the MockBot also has to be reworked a little. However, I reread the contributing doc and set up my environment to run the tests locally before pushing the changes and I receive some other errors like |
|
@saschalalala make sure to read the installation instructions carefully. You did not pull the submodule. Easiest way to fix is running |
|
Okay, thanks. I overlooked that because I only read the contributing guide m( The tests are running fine on my machine now. |
|
@saschalalala thanks for pointing that out, we need to add this change in our contributing guide aswell. |
|
Is there anything I can do regarding the two failed tests or are they related to the test environment and network issues? |
this needs to be fixed, the timed out error is nothing to worry about. |
|
This looks great, thank you for the effort! |
I renamed some functions in message.py to snake case for consistency. Are there any other files that need function renaming?