Skip to content

Conversation

@saschalalala
Copy link
Contributor

I renamed some functions in message.py to snake case for consistency. Are there any other files that need function renaming?

@jsmnbom
Copy link
Member

jsmnbom commented Jun 11, 2017

I know there are a few other places... maybe if you search for "*args, **kwargs" or something you'll find them..
Also you can add yourself to AUTHORS.rst if you want :)

Copy link
Member

@tsnoam tsnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If Travis approves we can merge.

@saschalalala
Copy link
Contributor Author

saschalalala commented Jun 11, 2017

Found some more, working on it.
Nevermind, I was in the wrong branch :D

@saschalalala
Copy link
Contributor Author

Ok. There is more. Give me one or two days to look through the code, there are some files, I did not look at yet.

@saschalalala
Copy link
Contributor Author

Ok, I'm done. I read through all the code and will go to bed now. That should really have been it now.

@jh0ker
Copy link
Member

jh0ker commented Jun 11, 2017

@saschalalala Good night :)

@saschalalala
Copy link
Contributor Author

Okay, some tests fail because the MockBot also has to be reworked a little. However, I reread the contributing doc and set up my environment to run the tests locally before pushing the changes and I receive some other errors like ModuleNotFoundError: No module named 'telegram.vendor.ptb_urllib3.urllib3' Anything I can do about that?

@Eldinnie
Copy link
Member

@saschalalala make sure to read the installation instructions carefully. You did not pull the submodule. Easiest way to fix is running git submodule update --init --recursive

@saschalalala
Copy link
Contributor Author

Okay, thanks. I overlooked that because I only read the contributing guide m(

The tests are running fine on my machine now.

@Eldinnie
Copy link
Member

@saschalalala thanks for pointing that out, we need to add this change in our contributing guide aswell.

@saschalalala
Copy link
Contributor Author

Is there anything I can do regarding the two failed tests or are they related to the test environment and network issues?

@Eldinnie
Copy link
Member

Flake8...................................................................Failed
hookid: flake8
telegram/precheckoutquery.py:98:100: E501 line too long (101 > 99 characters)

this needs to be fixed, the timed out error is nothing to worry about.

@jh0ker jh0ker added ⚙️ documentation affected functionality: documentation enhancement labels Jun 12, 2017
@jh0ker
Copy link
Member

jh0ker commented Jun 13, 2017

This looks great, thank you for the effort!

@jh0ker jh0ker merged commit 3863b4f into python-telegram-bot:master Jun 13, 2017
@saschalalala saschalalala deleted the renaming_functions branch June 18, 2017 10:23
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2020
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ documentation affected functionality: documentation 🔌 enhancement pr description: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants