Add VideoNote #625
Merged
Add VideoNote #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deprecation is totally gonna come back and bite us when the regexp gets removed completely in never version´
tsnoam
requested changes
May 22, 2017
| long. Use this method to send video messages | ||
| Args: | ||
| chat_id (int|str): Unique identifier for the message recipient - Chat id. |
Member
There was a problem hiding this comment.
s/voice/vide_note/
type: InputFile|str
| url = '{0}/sendVideoNote'.format(self.base_url) | ||
|
|
||
| data = {'chat_id': chat_id, 'video_note': video_note} | ||
|
|
Member
There was a problem hiding this comment.
if duration is not None
(and same for length below)
Member
Author
There was a problem hiding this comment.
Sure? We don't do that anywhere else in bot.py?
telegram/inputfile.py
Outdated
| self.input_file = data.pop('certificate') | ||
| elif 'video_note' in data: | ||
| self.input_name = 'video_note' | ||
| self.input_file = data.pop('video_note') |
Member
There was a problem hiding this comment.
I wonder - we have a lot of branching here. Should we move to a dict here? It's much more pythonic.
Member
Author
There was a problem hiding this comment.
Not sure what you meant.. does this work?
telegram/inputfile.py
Outdated
| ]) | ||
|
|
||
| # Add input_file to upload | ||
| # Add input_file to upload |
Member
There was a problem hiding this comment.
Please return the leading indentation
telegram/message.py
Outdated
| sticker=None, | ||
| video=None, | ||
| voice=None, | ||
| video_note=None, |
Member
There was a problem hiding this comment.
Same note like I left on #628 - should new parameters be added in the middle or in the end of the function?
tsnoam
approved these changes
May 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #617
This is where it gets weird....
According to telegram length is Video width and height.. but how that works with one parameter I couldn't tell you.. it also seems to be required but is not marked as such in the documentation....