Skip to content

Updated docstring in deleteMessage methods - #618

Merged
jh0ker merged 3 commits into
python-telegram-bot:masterfrom
evgfilim1:delete-message
May 19, 2017
Merged

Updated docstring in deleteMessage methods#618
jh0ker merged 3 commits into
python-telegram-bot:masterfrom
evgfilim1:delete-message

Conversation

@evgfilim1

@evgfilim1 evgfilim1 commented May 19, 2017

Copy link
Copy Markdown
Contributor

Fixes #617 a bit

@jsmnbom

jsmnbom commented May 19, 2017

Copy link
Copy Markdown
Member

Could you update the docstring to include the description of the bot api while you're at it?

@evgfilim1

Copy link
Copy Markdown
Contributor Author

@bomjacob I should copy method description from Bot API documentation and put it in docstring, right?

@jh0ker

jh0ker commented May 19, 2017

Copy link
Copy Markdown
Member

@evgfilim1 Yes

@evgfilim1 evgfilim1 changed the title Removed "undocumented" notice in deleteMessage methods Updated docstring in deleteMessage methods May 19, 2017
@evgfilim1

Copy link
Copy Markdown
Contributor Author

@bomjacob @jh0ker Done

Comment thread telegram/bot.py Outdated
@channelusername).
message_id (Optional[int]): Required if inline_message_id is not specified. Unique
identifier of the sent message.
inline_message_id (Optional[str]): Required if chat_id and message_id are not

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you accidentally a line

@evgfilim1

Copy link
Copy Markdown
Contributor Author

@jh0ker Fixed

@jh0ker
jh0ker merged commit c2c5452 into python-telegram-bot:master May 19, 2017
@evgfilim1
evgfilim1 deleted the delete-message branch May 19, 2017 18:31
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

May 18 changes

3 participants