Improved CommandHandler - #613
Merged
jh0ker merged 5 commits intoMay 19, 2017
Merged
Conversation
Now you can pass list of commands instead of one command
Renamed `commands` to `command` in CommandHandler
jh0ker
reviewed
May 19, 2017
| pass_user_data=pass_user_data, | ||
| pass_chat_data=pass_chat_data) | ||
| self.command = command | ||
| if isinstance(command, str): |
Member
There was a problem hiding this comment.
this could fail on python 2, if command is a unicode string
Contributor
Author
|
@jh0ker Fixed |
Member
|
Thanks :) I'll merge once the Travis tests are green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now you can pass list of commands instead of one command
It will be useful when you define some aliases for command or if commands (such as
/startand/help) has the same behaviour