Skip to content

Fix Bug #571 (second try) - #574

Merged
jh0ker merged 2 commits into
python-telegram-bot:masterfrom
manorom:fix-571
Apr 29, 2017
Merged

Fix Bug #571 (second try)#574
jh0ker merged 2 commits into
python-telegram-bot:masterfrom
manorom:fix-571

Conversation

@manorom

@manorom manorom commented Apr 23, 2017

Copy link
Copy Markdown
Contributor

ConversationHandler will not process CallbackQuery if per_chat=True and
the CallbackQuery has no message attached to it (as is the case with
buttons on inline results)

ConversationHandler will not process CallbackQuery if per_chat=True and
the CallbackQuery has no message attached to it (as is the case with
buttons on inline results)
@jh0ker

jh0ker commented Apr 23, 2017

Copy link
Copy Markdown
Member

Thank you for your contribution! I would appreciate if you could add a test case for this behaviour in /tests/test_conversationhandler.py
Also, feel free to add yourself to AUTHORS.rst :)

@jh0ker jh0ker added bug 📋 pending-reply work status: pending-reply labels Apr 25, 2017
@manorom

manorom commented Apr 28, 2017

Copy link
Copy Markdown
Contributor Author

I'm not 100% sure, but i think 8182dea should catch the error

@jh0ker jh0ker removed the 📋 pending-reply work status: pending-reply label Apr 29, 2017
@jh0ker
jh0ker merged commit c5598b9 into python-telegram-bot:master Apr 29, 2017
@jh0ker

jh0ker commented Apr 29, 2017

Copy link
Copy Markdown
Member

Thank you :)

@manorom
manorom deleted the fix-571 branch April 29, 2017 14:51
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 24, 2020
@Bibo-Joshi Bibo-Joshi added 🔌 bug pr description: bug and removed bug 🐛 labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔌 bug pr description: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants