Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5231
I could not get the lazy imports feature to actually fully work with our library, somewhere along the path all dependencies are eagerly resolved. Doing
lazy import telegramdoes work and everything is lazy, until you first use just one class, and then everything is imported all at once, which defeats the point. I may look more deeply into this later.There are other some non-critical warnings which show up, related to sphinx, but so far I've not noticed that breaking anything. Tracking issue: PEP 829:
KeyError: "local variable ''sitedir'' is not defined"python/cpython#149671This PR also bumps the cryptography version, which allows it to build on 3.15.
Free threaded build fails on 3.15 due to cryptography fails to build on 3.15t with uv pyca/cryptography#14983. For now we should say that we don't fully support 3.15t.