Skip to content

set timeout for post message with file object#486

Merged
tsnoam merged 5 commits into
python-telegram-bot:masterfrom
anton-tagunov:master
Dec 29, 2016
Merged

set timeout for post message with file object#486
tsnoam merged 5 commits into
python-telegram-bot:masterfrom
anton-tagunov:master

Conversation

@anton-tagunov

Copy link
Copy Markdown
Contributor

Timeout is not set for POST method when the message contains file object, for example for the sendPhoto method.

@jh0ker

jh0ker commented Dec 18, 2016

Copy link
Copy Markdown
Member

Thank you for your PR, good catch! It seems you didn't set up the precommit hooks as it is described in our contribution guide, which is why Travis is complaining. Would you mind fixing that?
Also, if you haven't done so already, you can add yourself to AUTHORS.rst

@jh0ker jh0ker added the bug label Dec 18, 2016
@MWeesenaar

Copy link
Copy Markdown
Contributor

LGTM.

@tsnoam

tsnoam commented Dec 29, 2016

Copy link
Copy Markdown
Member

f*** yapf, we'll fix style it in our master branch later.
thank you for your contribution @anton-tagunov

@tsnoam tsnoam merged commit 48bcc31 into python-telegram-bot:master Dec 29, 2016
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 24, 2020
@Bibo-Joshi Bibo-Joshi added 🔌 bug pr description: bug and removed bug 🐛 labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔌 bug pr description: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants