Skip to content

API changes of December 04 (Bot API 2.3.1) - #483

Merged
jh0ker merged 10 commits into
masterfrom
dec04
Feb 27, 2017
Merged

API changes of December 04 (Bot API 2.3.1)#483
jh0ker merged 10 commits into
masterfrom
dec04

Conversation

@jh0ker

@jh0ker jh0ker commented Dec 13, 2016

Copy link
Copy Markdown
Member
  • Use the new field max_connections in setWebhook to optimize your bot's server load
  • Use allowed_updates in setWebhook and getUpdates to selectively subscribe to updates of a certain type. Among other things, this allows you to stop getting updates about new posts in channels where your bot is an admin.
  • deleteWebhook moved out of setWebhook to get a whole separate method for itself.

I also renamed the webhook_url parameter of setWebhook to url like in the official API. The old name is still supported through kwargs.

@jh0ker jh0ker added the ⚙️ bot-api affected functionality: bot-api label Dec 13, 2016
@tsnoam

tsnoam commented Dec 14, 2016

Copy link
Copy Markdown
Member

Generally, looks ok. Two things come to mind:

  1. Need to update Updater._bootstrap() so it will use deleteWebHook where applicable.
  2. Since we don't unitest that part, make sure to manually test it.

@jsmnbom jsmnbom mentioned this pull request Jan 13, 2017
Merged
@jh0ker
jh0ker merged commit 86c8ebb into master Feb 27, 2017
jh0ker added a commit that referenced this pull request Feb 27, 2017
@jh0ker
🔀 Merge master into dec04
a1ade40 
 #483
@jh0ker jh0ker mentioned this pull request Mar 24, 2017
Closed
@jsmnbom
jsmnbom deleted the dec04 branch May 20, 2017 13:51
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

⚙️ bot-api affected functionality: bot-api

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jh0ker @tsnoam