Api 9.0 business methods #4757
Api 9.0 business methods #4757
Conversation
aelkheir
left a comment
aelkheir
left a comment
There was a problem hiding this comment.
Hey! Changes look good 😄 , just left some minor comments.
| user = User(1, "first", False) | ||
| user_chat_id = 1 | ||
| date = dtm.datetime.utcnow() | ||
| can_reply = True |
There was a problem hiding this comment.
just a reminder this will also need to be adjusted if/when
- Added the class BusinessBotRights and replaced the field can_reply with the field rights of the type BusinessBotRights in the class BusinessConnection.
gets merged first.
harshil21
left a comment
harshil21
left a comment
There was a problem hiding this comment.
the set_business_account_profile_photo and remove_business_account_profile_photo methods are missing, not sure if that was intentional or not...
I'm fine with the naming of message.read_business_message. Rest of the changes look good to me!
Yup, those require new classes which I didn't have time to implement yet :)
🥳 |
Co-authored-by: Abdelrahman Elkheir <90580077+aelkheir@users.noreply.github.com>
Message.read_business_messagecan be discussed. JustMessage.readdoesn't sufficiently highlight the business connection IMO butMessage.read_business_messageis the complete name again … not really happy with it.