Botapi2.3 #471
Merged
Botapi2.3 #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed behaviour: messages with high scores will be update with new high scores by default. (documentation fix) - Use (new) disable_edit_message in setGameScore to disable the above new behaviour. - The edit_message parameter from setGameScore is no longer in use. For backward compatibility, it will be taken into account for a while, unless disable_edit_message is passed explicitly. refs #468
Telegram servers changed their behaviour - now they truncate a long caption instead of returning an error.
jsmnbom
reviewed
Dec 4, 2016
| ``chat_data`` will be passed to the callback function. It will be a ``dict`` you | ||
| can use to keep any data related to the chat that the update was sent in. | ||
| For each update in the same chat, it will be the same ``dict``. Default is ``False``. | ||
| message_updates (Optional[bool]): Should "normal" message updates be handled? Default is |
Member
There was a problem hiding this comment.
I wonder if we could use a filter for this instead? Now that it is actually possible to use more than one filter. Or is it more clear/explicit and nice using this method?
Member
There was a problem hiding this comment.
I think this is okay, it's also the same way as we implemented edited messages
jsmnbom
approved these changes
Dec 4, 2016
Member
jsmnbom
left a comment
jsmnbom
left a comment
There was a problem hiding this comment.
Overall looks good! ^^
The deprecation of ReplyKeyboardHide is a bit ugly, but it works (and I can't think of a better way :P)
Closed
jh0ker
approved these changes
Dec 11, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #468