Add pass_user_data and pass_chat_data to Handler #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jh0ker
changed the title
|
LGTM 👍. Any idea on when this'll be merged? |
evieluvsrainbows
approved these changes
Oct 25, 2016
Member
Author
|
@KamranMackey Once someone reviewed it ;) |
|
@jh0ker I reviewed it. I approved the changes 😄 |
jsmnbom
reviewed
Oct 25, 2016
examples/conversationbot2.py
Outdated
| bot. | ||
| """ | ||
|
|
||
| from telegram import (ReplyKeyboardMarkup) |
Member
There was a problem hiding this comment.
Is there a reason to have parenthesis here? If not, it might be a good idea to remove it considering this is an example bot.
| custom_choice), | ||
| ], | ||
|
|
||
| TYPING_CHOICE: [MessageHandler([Filters.text], |
Member
There was a problem hiding this comment.
Due to the bitwise-filters PR this will raise a warning. Just so you're aware.
Member
Author
There was a problem hiding this comment.
Oh this was already merged, right ^^
Member
Author
There was a problem hiding this comment.
On a second thought, I'll wait with that till the release
Member
There was a problem hiding this comment.
Alright, should probably change throughout our examples at that point then :)
Bibo-Joshi
added
🔌 enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A solution for #385
Not exactly what was requested, but very close and more versatile. Any handler can now request the
user_dataparameter, which is adict. You can use it to store any data that is related to the user who sent the update. When the user sends another update, it will be the samedictwith the same contents, across all handlers.A
chat_datafollowing the same concept has been added as well.