-
Notifications
You must be signed in to change notification settings - Fork 5.9k
API 7.3 Chat Backgrounds and new params #4247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API 7.3 Chat Backgrounds and new params #4247
Conversation
- [x] Added the field via_join_request to the class ChatMemberUpdated.
- [x] Added the parameter live_period to the method editMessageLiveLocation.
- [x] Added the classes `ChatBackground`, `BackgroundType`, `BackgroundFill` and the field `chat_background_set` of type `ChatBackground` to the class Message, describing service messages about background changes
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the nice PR! I've added a few comments
|
Thanks for reviewing! Addressed comments. |
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fast updates - just one new comment :)
* sort constants.__all__ * properly annotate `self.colors = parse_sequence_arg(..)`
please pass V
|
Thank you very much for the helpful PR 👏 |
Closes #4236
Describe the solution you'd like
Added the field question_entities to the class PollAdded the field text_entities to the class PollOptionAdded the parameters question_parse_mode and question_entities to the method sendPollCheck-list for PRs
.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSIONor.. deprecated:: NEXT.VERSIONto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)CSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__AUTHORS.rst(optional)__all__sStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behaviorIf the PR contains API changes (otherwise, you can ignore this passage)
Checked the Bot API
Stability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_see here <https://docs.python-telegram-bot.org/en/stable/stability_policy.html#case-2>_)self._id_attrsand corresponding documentation__init__acceptsapi_kwargsas kw-only~telegram.Chat& :class:~telegram.Userfor all methods that acceptchat/user_id~telegram.Messagefor all methods that acceptchat_idandmessage_id~telegram.Messageshortcuts: Addedquoteargument if methods acceptsreply_to_message_id~telegram.CallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idtelegram.constantsand shortcuts to them as class variablestelegram.Message.effective_attachment~telegram.ext.ConversationHandler_extbot.pybot_methods.rstREADME.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSION_INFOtelegram.ext.ExtBotfor new methods that either accept areply_markupin some form or have a return type that is/contains :class:~telegram.Message