Skip to content

Add edit_* class methods - #423

Merged
jsmnbom merged 3 commits into
masterfrom
edit-class-method
Oct 15, 2016
Merged

Add edit_* class methods#423
jsmnbom merged 3 commits into
masterfrom
edit-class-method

Conversation

@jsmnbom

@jsmnbom jsmnbom commented Sep 25, 2016

Copy link
Copy Markdown
Member

Adds edit_* methods to message and callbackquery.
The ones in callbackquery check if the query came from a normal or inline message and acts accordingly.

Only thing I'm not sure about is how to test the edit_message_* methods in CallbackQuery, since we can't exactly send a callbackquery to the test bot every time we run tests, can we?

I'd also love to hear if anyone has got a better way to do the docstring for edit_message_text to also make it look good in source (currently I'm prioritising it looking good in the sphinx build).

Either edits the message attribute, or the message associated with the inline_message_id.
@jsmnbom jsmnbom added enhancement 📋 pending-review work status: pending-review labels Sep 25, 2016

@jh0ker jh0ker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsmnbom
jsmnbom merged commit a5671a8 into master Oct 15, 2016
@jsmnbom
jsmnbom deleted the edit-class-method branch October 17, 2016 10:26
@jsmnbom jsmnbom removed the 📋 pending-review work status: pending-review label Oct 19, 2016
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 24, 2020
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔌 enhancement pr description: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants