Migrate from setup.cfg to pyproject.toml
#4088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
|
Well we aren't on pythonhosted anymore. I don't see any reason keeping that in our config. |
Bibo-Joshi
reviewed
Feb 1, 2024
Member
Bibo-Joshi
left a comment
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Fully agree on the general idea 👍
- license-files: If you're able to move to pyproject, I'm ofc happy. test-meta just checks the return code of
python setup.py bdist_dumb, so running that manually should probably give you an idea of the exception - sphinx-pypi-upload: I agree with pool, ditch that
Member
Author
there was some error regarding the parsing of pyproject.toml, I'll have a closer look later |
Member
Author
Leaving this for now, since we will be discussing if it's worth to ditch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to do this for a long time. Having two config files is just unnecessary since
pyproject.tomlis now the recommended config file for tools, linters, packaging, etc.So this PR migrates all the tools to use
pyproject.tomlinstead. There are only 3 remaining:license-files: Seems like this breakstest_meta.py? Otherwise it's possible to move it topyproject.tomlaccording to their docs.sphinx-pypi-upload: This was added by leandro 8 years ago, back when docs were uploaded not to RTD, but to pythonhosted.org. I recommend removing that dependency and from thesetup.cfg(upload_sphinx,build_sphinx). More information on that method can be found here.flake8: Unfortunately, flake8 does not support pyproject.toml due to some weird reason (shame!) - pyproject.toml (PEP 518) support PyCQA/flake8#234 but we should be able to removeflake8onceruffbecomes stable.