-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Flag emojis #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flag emojis #384
Conversation
|
I personally don't believe that this is the way that it should be implemented... Instead of having the individual countries, I would implement the individual letters instead (U+1F1E6 through U+1F1FF), since a country's flags and borders can change at any time (and would then require an update). |
|
Maybe it would be better to put them into a separate file. EDIT1: On the other hand, maybe I could implement both names and country codes. 8) EDIT2: Would be great if we could do |
|
I really don't think it's necessary to have it be reference-able as both HoweverIf I'm being 100% honest I believe that the current |
|
@bomjacob Maybe we can just remove it all together and tell users to install that emoji module? |
|
That could definitely work, we should probably test that there's not some weird edge case with telegram we're missing (missing emojis or whatever). But I definitely like that module a whole lot better than the current solution. Edit: If there's any of the emojis that telegram doesn't support or something like that. We could create a fork of it https://github.com/carpedm20/emoji at https://github.com/python-telegram-bot ? |
|
Sounds like a plan. Not sure how to do it properly though. Shall we add it to |
|
Neither... |
|
Maybe. After all, in Python3 we can simply copypaste needed emojis right into our code and refrain from using any emoji module altogether. |
|
I have just extended the Emoji with this class, which contains Unicode characters I need that are not included in the Emoji package, and a very short function that takes a country code and returns the flags Emoji: |
|
@Lumiukko I'm really not sure that we wanna include that in the library for two reasons:
|
|
Sorry for the confusion. That was supposed to be an argument against including flag and other emoji into this library, because extending is quite simple -- of which my code was supposed to be an example for. |
|
@Lumiukko Ohhh, okay, sorry for the misunderstanding then :) |
I agree with @jh0ker and @bomjacob that recommending the We'll have to keep the emoji class for backwards compatibility for a while though. |
|
I will close this then, thank you for your contribution still! |
Added the country flags to emoji file for easier calling.
Took them from here and deleted the ones that Telegram doesn't support yet. Maybe not all flags supported by Telegram were included.