Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Jun 26, 2023

Makes sure that some artifacts that currently always clutter my root directory are properly removed.

Already makes use of the missing_ok parameter in anticipation of #3728 and should hence be merged after that.

@Bibo-Joshi Bibo-Joshi requested review from Poolitzer and clot27 June 26, 2023 17:22
@Bibo-Joshi Bibo-Joshi added the ⚙️ tests affected functionality: tests label Jun 26, 2023
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we use the tmp_path pytest fixture?

@Bibo-Joshi
Copy link
Member Author

can't we use the tmp_path pytest fixture?

Nice idea! writing to those files gives me permisison denied errors currently. Will have a look if I can fix that.

# Conflicts:
#	tests/_files/test_animation.py
#	tests/_files/test_audio.py
#	tests/_files/test_chatphoto.py
#	tests/_files/test_document.py
#	tests/_files/test_photo.py
#	tests/_files/test_sticker.py
#	tests/_files/test_video.py
#	tests/_files/test_videonote.py
#	tests/_files/test_voice.py
@Bibo-Joshi Bibo-Joshi merged commit 5534ddf into master Jul 3, 2023
@Bibo-Joshi Bibo-Joshi deleted the delete-test-artifacts branch July 3, 2023 08:06
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ tests affected functionality: tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants