Pass name to asyncio.create_task
#3759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@harshil21 IISC the point is that the call to application.create_task ensures that the job will be awaited on shutdown... |
by using Event based test than a timed one
Bibo-Joshi
reviewed
Jun 20, 2023
Member
Bibo-Joshi
left a comment
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the PR! :) Left a few suggestions below. Sorry for the brief wording, I'm not at a keyboard...
Bibo-Joshi
reviewed
Jun 25, 2023
17 tasks
Bibo-Joshi
added a commit
that referenced
this pull request
Jun 29, 2023
…#3764, #3762, #3759) Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com> Co-authored-by: Luca Bellanti <luca.bellanti@gmail.com> Co-authored-by: thefunkycat <104379699+thefunkycat@users.noreply.github.com> Co-authored-by: Aditya Yadav <69784758+clot27@users.noreply.github.com> Co-authored-by: Dmitry Kolomatskiy <58207913+lemontree210@users.noreply.github.com>
clot27
added a commit
that referenced
this pull request
Jul 3, 2023
…#3764, #3762, #3759) Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com> Co-authored-by: Luca Bellanti <luca.bellanti@gmail.com> Co-authored-by: thefunkycat <104379699+thefunkycat@users.noreply.github.com> Co-authored-by: Aditya Yadav <69784758+clot27@users.noreply.github.com> Co-authored-by: Dmitry Kolomatskiy <58207913+lemontree210@users.noreply.github.com>
Bibo-Joshi
added
🔌 enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3733
I couldn't test the
nameinJob._runsince that task is instantly awaited (why?)