Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Apr 23, 2023

Noticed by chance that type completeness has dropped. Trying to fix both that and the corresponding worflow. Workflow first.

Based on the API 6.7 branch because that's where I noticed stuff going wrong. Master may have been better, but now it's too late :D

To be merged after #3673

  • Reactivate unit tests
  • remove api-6.7 branch from workflow file

@Bibo-Joshi Bibo-Joshi added ⚙️ tests affected functionality: tests ⚙️ type-hinting affected functionality: type-hinting labels Apr 23, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

@Bibo-Joshi Bibo-Joshi changed the base branch from master to api-6.7 April 23, 2023 09:50
@Bibo-Joshi
Copy link
Member Author

FYI: apparently it's still not possible to display the type completeness status in the checks overview (similar to what codecov does). I openend https://github.com/orgs/community/discussions/53528 about that.

Base automatically changed from api-6.7 to master May 7, 2023 11:44
@Bibo-Joshi Bibo-Joshi marked this pull request as ready for review May 7, 2023 11:52
@Bibo-Joshi Bibo-Joshi merged commit 66b6d3c into master May 7, 2023
@Bibo-Joshi Bibo-Joshi deleted the type-completeness branch May 7, 2023 12:10
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ tests affected functionality: tests ⚙️ type-hinting affected functionality: type-hinting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants