Skip to content

API 6.4 #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 29 commits into from
Jan 1, 2023
Merged

API 6.4 #3449

Bibo-Joshi merged 29 commits into from
Jan 1, 2023

Conversation

@harshil21
Copy link
Member

@harshil21 harshil21 commented Dec 30, 2022 •
edited
Loading

New API update

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

If the PR contains API changes (otherwise, you can delete this passage)

  • New classes:

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts api_kwargs as kw-only

  • Added new shortcuts:

    • In Chat & User for all methods that accept chat/user_id
    • In Message for all methods that accept chat_id and message_id
    • For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id
    • In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id

  • If relevant:

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Link new and existing constants in docstrings instead of hard coded number and strings
    • Add new message types to Message.effective_attachment
    • Added new handlers for new update types
      • Add the handlers to the warning loop in the ConversationHandler
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added the new method(s) to _extbot.py
    • Added or updated bot_methods.rst
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION_INFO
    • Added logic for arbitrary callback data in tg.ext.Bot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

@harshil21 harshil21 added the ⚙️ bot-api affected functionality: bot-api label Dec 30, 2022
@harshil21 harshil21 added this to the v20.0 milestone Dec 30, 2022
harshil21 and others added 12 commits December 30, 2022 19:20
github-actions[bot]
github-actions bot reviewed Dec 30, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

Bibo-Joshi
Bibo-Joshi requested changes Dec 31, 2022
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR, thanks for being so quick! In addition to a few specific comments:

  • in test_inputmedia.py it would be good if we added a test to TestSendMediaGroup about sending with spoiler
  • similar for test_{photo, video, animation}

@harshil21
Copy link
Member Author

harshil21 commented Jan 1, 2023

  • similar for test_{photo, video, animation}

we already test spoilers in test_send_all_args, do you mean a separate test just for that?

@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Jan 1, 2023

  • similar for test_{photo, video, animation}

we already test spoilers in test_send_all_args, do you mean a separate test just for that?

ah, no, I'm just blind :D

@Bibo-Joshi
Merge branch 'master' into api_6.4
af4df5d 
# Conflicts:
#	telegram/_forumtopic.py
@Bibo-Joshi Bibo-Joshi merged commit 606773d into master Jan 1, 2023
@Bibo-Joshi Bibo-Joshi deleted the api_6.4 branch January 1, 2023 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Bibo-Joshi Bibo-Joshi Bibo-Joshi requested changes

Assignees

No one assigned

Labels

⚙️ bot-api affected functionality: bot-api

Projects

None yet

Milestone

v20.0

Development

Successfully merging this pull request may close these issues.

5 participants

@harshil21 @Bibo-Joshi @Poolitzer @lemontree210