API 6.3 #3346

harshil21 · 2022-11-06T15:13:02Z

Gathering all commits/fixes/PRs for the new and big 6.3 update.

Update tests for new forum methods - see here
revert changes to the test config

Checklist for PRs

Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
Created new or adapted existing unit tests
Documented code changes according to the CSI standard
~~Added myself alphabetically to AUTHORS.rst (optional)~~
Added new classes & modules to the docs and all suitable __all__ s

If the PR contains API changes (otherwise, you can delete this passage)

New classes:
- Added self._id_attrs and corresponding documentation
- __init__ accepts **_kwargs
Added new shortcuts:
- In Chat & User for all methods that accept chat/user_id
- In Message for all methods that accept chat_id and message_id
- ~~For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id~~
- ~~In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id~~
If relevant:
- Added new constants at telegram.constants and shortcuts to them as class variables
- Link new and existing constants in docstrings instead of hard coded number and strings
- ~~Add new message types to Message.effective_attachment~~
- ~~Added new handlers for new update types~~
  - ~~Add the handlers to the warning loop in the ConversationHandler~~
- Added new filters for new message (sub)types
- Added or updated documentation for the changed class(es) and/or method(s)
- Added or updated bot_methods.rst
- Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION
- ~~Added logic for arbitrary callback data in tg.ext.Bot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message~~

…_topic_message` to `Message` (#3345)

# Conflicts: # tests/test_bot.py

# Conflicts: # telegram/_bot.py # telegram/_message.py

Co-authored-by: Aditya Yadav <adityayadav11082@gmail.com> Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com> Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>

…icClosed`, `ForumTopicReopened` (#3356) Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com> Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>

Bibo-Joshi · 2022-11-18T15:59:38Z

Requesting reviews from everyone 🕺 Will try to review sometime this weekend
Smaller stuff can be pushed directly into this branch by everyone IMO. For things that you feel like they need discussion, leave a comment :)

telegram/_bot.py

telegram/ext/filters.py

github-actions

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

the TODO was asking about whether we should test a `str` identifier of a chat (right now only `int` is tested) It was agreed that additional tests were not needed and we will trust Telegram's behaviour

colors are automatically converted to `int`. User should be able to see that we mean HEX colors listed in Telegram API

lemontree210

Obviously, given my lack of in-depth knowledge, this is not mostly nitpicking: this is only nitpicking 😄

tests/test_chat.py

tests/test_filters.py

lemontree210

Changes suggested based on my work on #3351 . I can implement the changes myself, should there be no objections

telegram/constants.py

telegram/_bot.py

telegram/constants.py

Bibo-Joshi

Went through the code (but skipped the tests). Only have two comments :)

telegram/constants.py

tests/bots.py

telegram/ext/filters.py

Poolitzer

Didnt see an issue here, gj us claps on the back

clot27

LGTM

# Conflicts: # docs/substitutions/global.rst

Feat: New attributes for chat

74d1528

harshil21 added the ⚙️ bot-api affected functionality: bot-api label Nov 6, 2022

harshil21 added this to the v20.0a5 milestone Nov 6, 2022

harshil21 linked an issue Nov 6, 2022 that may be closed by this pull request

[Feature] Bot API 6.3 update #3340

Closed

13 tasks

Bibo-Joshi and others added 17 commits November 6, 2022 22:20

Update fallback bots and add forum_group_id fixture

2cd6c54

doc fix

f083fff

Merge remote-tracking branch 'origin/master' into api_6.3_update

0b597d9

Fix: black

7dc634e

add message_thread_id param to methods, message_thread_id and `is…

3e8aa6e

…_topic_message` to `Message` (#3345)

Feat: Docstring changes + moving limit to constants (#3343)

d48499f

Merge branch 'master' into api_6.3_update

7463346

# Conflicts: # tests/test_bot.py

Fix: Pycharm messing with me

1ebb561

Some part of the new api update (#3342)

7cb99c6

post-merge review of #3342

48c04d5

Merge branch 'master' into api_6.3_update

b8837ad

temporarily enable tests for PRs agains this branch

2fd5538

update two shorcut methods

2c8a1c0

Merge branch 'master' into api_6.3_update

897105c

# Conflicts: # telegram/_bot.py # telegram/_message.py

6.3 new methods (#3360)

addaa6d

Co-authored-by: Aditya Yadav <adityayadav11082@gmail.com> Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com> Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>

small doc fix

3940b53

New classes for API 6.3: ForumTopic, ForumTopicCreated, `ForumTop…

0cc1d03

…icClosed`, `ForumTopicReopened` (#3356) Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com> Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>

Bibo-Joshi requested review from Bibo-Joshi, Poolitzer, clot27 and lemontree210 November 18, 2022 15:58

harshil21 commented Nov 18, 2022

View reviewed changes

telegram/_bot.py Show resolved Hide resolved

telegram/_bot.py Show resolved Hide resolved

telegram/_bot.py Outdated Show resolved Hide resolved

telegram/_bot.py Show resolved Hide resolved

telegram/ext/filters.py Show resolved Hide resolved

review + fixes: fix coverage and some docs

86b2a55

harshil21 mentioned this pull request Nov 18, 2022

Add caption, caption_entities as parameters to Bot._send_message #3372

Closed

update bot api version number

1d78410

harshil21 added 2 commits November 19, 2022 03:27

add xfail marker to test

8afae2d

revert changes to test config

84a1693

github-actions bot reviewed Nov 18, 2022

View reviewed changes

lemontree210 added 4 commits November 19, 2022 13:16

minor(test_forum.py): remove TODO

fa917c8

the TODO was asking about whether we should test a `str` identifier of a chat (right now only `int` is tested) It was agreed that additional tests were not needed and we will trust Telegram's behaviour

minor(ChatPermissions) move "and" in docstring

eef0a48

minor(ChatPermissions) add comma before attr in docstring

330e483

minor(constants.ForumIconColor) add HEX equivalents in docstr

e63eae3

colors are automatically converted to `int`. User should be able to see that we mean HEX colors listed in Telegram API

lemontree210 reviewed Nov 19, 2022

View reviewed changes

tests/test_chat.py Show resolved Hide resolved

tests/test_chat.py Show resolved Hide resolved

tests/test_filters.py Show resolved Hide resolved

lemontree210 requested changes Nov 20, 2022

View reviewed changes

telegram/constants.py Outdated Show resolved Hide resolved

telegram/constants.py Outdated Show resolved Hide resolved

telegram/constants.py Outdated Show resolved Hide resolved

telegram/_bot.py Outdated Show resolved Hide resolved

lemontree210 added 2 commits November 20, 2022 15:12

refactor(constants) ChatLimit -> TitleLimit

a0f5e93

minor(constants) add refs to params in docstrings of TopicLimit

444e999

lemontree210 reviewed Nov 20, 2022

View reviewed changes

telegram/constants.py Outdated Show resolved Hide resolved

Bibo-Joshi reviewed Nov 20, 2022

View reviewed changes

telegram/constants.py Outdated Show resolved Hide resolved

tests/bots.py Show resolved Hide resolved

lemontree210 and others added 4 commits November 20, 2022 20:50

minor(constants): rename TitleLimit->ChatLimit, move it up in code

937544b

minor(constants): rename TopicLimit->ForumTopicLimit

101b8e4

minor(constants): sort __all__ alphabetically

fba5421

filters.IS_TOPIC_MESSAGE

2f624e2

harshil21 commented Nov 21, 2022

View reviewed changes

telegram/ext/filters.py Show resolved Hide resolved

Poolitzer approved these changes Nov 21, 2022

View reviewed changes

clot27 approved these changes Nov 21, 2022

View reviewed changes

Bibo-Joshi added 2 commits November 22, 2022 10:37

Update filters.__all__ and add a unit test

c0f4c2f

Merge branch 'master' into api_6.3_update

3dbd118

# Conflicts: # docs/substitutions/global.rst

Bibo-Joshi merged commit caacafa into master Nov 22, 2022

Bibo-Joshi deleted the api_6.3_update branch November 22, 2022 09:43

Poolitzer mentioned this pull request Nov 25, 2022

API 6.3 for V13 #3392

Merged

github-actions bot locked and limited conversation to collaborators Nov 29, 2022

API 6.3 #3346

API 6.3 #3346

Uh oh!

Conversation

harshil21 commented Nov 6, 2022 • edited by Bibo-Joshi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist for PRs

If the PR contains API changes (otherwise, you can delete this passage)

Uh oh!

Bibo-Joshi commented Nov 18, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

lemontree210 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lemontree210 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Bibo-Joshi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Poolitzer left a comment

Choose a reason for hiding this comment

Uh oh!

clot27 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

harshil21 commented Nov 6, 2022 •

edited by Bibo-Joshi

Loading

lemontree210 left a comment •

edited

Loading