Add recursive parameter to TO.to_dict()
#3276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix _get_attrs for non-slotted classes
make and use copy of data, since data increases length every iteration. Use generator to get all slots, and use hasattr() instead of try-except
harshil21
force-pushed
the
to_dict-recursion
branch
from
a89ac15 to
cc98b74
Compare
Bibo-Joshi
reviewed
Oct 17, 2022
Bibo-Joshi
reviewed
Oct 17, 2022
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
Bibo-Joshi
added
🔌 enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3146
I went with the simple boolean approach instead of specifying a number for the recursion.
Also based on the TO-overhaul branch since I had to make sure these changes work with that too. (Merge after #3233)
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)