Skip to content

Conversation

@tsnoam
Copy link
Member

@tsnoam tsnoam commented Jun 18, 2016

No description provided.

tsnoam and others added 25 commits May 30, 2016 01:05
globals are supposed to be upper case
this will better protect the user from wrong usage
during test_bootstrap_retries_fail() there is an exception raised (by
design): TelegramError('test')

For a reason I haven't managed to pinpoint the above exception in its
precise timing caused the Updater to be left in a state which is
'self.running == False', but the dispatcher threads already initialized.
This patch identifies this extreme case and makes sure to go over the
stop procedure.
even for the first unitest, it might come after another unitests from
another file which had already init the conpool.
telegram servers might send a reponse with HTTP 302 (redirect) to
another hostname. in such case HTTPSConnectionPool will fail to do the
job
@tsnoam
Copy link
Member Author

tsnoam commented Jun 18, 2016

failures in travis are due to yapf.
for some reason, my yapf and the one used in the travis build disagree.

@jh0ker
Copy link
Member

jh0ker commented Jun 19, 2016

LGTM

@jh0ker jh0ker added this to the 5.0 milestone Jun 19, 2016
@tsnoam tsnoam merged commit e0539d5 into master Jun 20, 2016
@leandrotoledo leandrotoledo deleted the urllib3 branch June 20, 2016 03:33
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2020
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔌 enhancement pr description: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants