Api 6.1 #3112
Api 6.1 #3112
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Bibo-Joshi
left a comment
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Neat! :) Had a first look through the changes and left some smaller comments below. Will try to have a look at the tests later
harshil21
left a comment
harshil21
left a comment
There was a problem hiding this comment.
Fast job!
To change:
- parameter
login_urlofLoginUrlshould be changed to sayHTTPS. - Also in https://t.me/c/1161850314/4292, they removed limits for text length and caption. Should we do that too? Or just document saying that premium users' bots' can write longer captions?
Bibo-Joshi
left a comment
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Only have a few comments for the test :)
There was a problem hiding this comment.
found out why docs were failing: Also see #3112 (comment)
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Bibo-Joshi
left a comment
Bibo-Joshi
left a comment
There was a problem hiding this comment.
I think apart from the two comments below I don't have anything else to add :) extending customwebhookbot.py to use the secret_token can surely be done in this PR but can also be done later on - might be another good first issue …
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
tests/test_sticker.py
Outdated
| async def test_premium_animation(self, bot): | ||
| # testing animation sucks a bit since we can't create a premium sticker. What we can do is | ||
| # get a sticker set which includes a premium sticker and check that specific one. | ||
| premium_sticker_chat = await bot.get_sticker_set("Flame") |
There was a problem hiding this comment.
yes, you don't get a sticker_chat, you get a set. https://docs.python-telegram-bot.org/en/v20.0a1/telegram.bot.html#telegram.Bot.get_sticker_set ;P
There was a problem hiding this comment.
That's my point: premium_sticker_chat -> premium_sticker_set ;P
There was a problem hiding this comment.
Ohh you meant the variable I only saw the request
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)__all__sIf the PR contains API changes (otherwise, you can delete this passage)
If relevant:
telegram.constantsand shortcuts to them as class variablesbot_methods.rstREADME.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSION