You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
agree, [ujson] is much clearer, but you need to extend existing setup to support both to backward compatibility. I'm not sure if extend will be ok, so I just fix readme to match code.
that's good thinking @Behoston ! however, we're by now working towards v14, which will break a lot of things anyway. So that wouldn't necessarily be a no-go. Anyway, while I somewhat like the idea to rename json to ujson, the former makes it easier for us to switch to another json-library if we see fit at some point. The other optional requirements socks and passport are also more a description of what the requirements are for, not which lib would be installed. So I think I'm slightly more in favor of adjusting the readme as you currently did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a readme fix.
https://github.com/python-telegram-bot/python-telegram-bot/blob/master/setup.py#L85