Make cryptography optional #2386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
Author
|
Upgrading pytest required a small workaround, see pytest-dev/pytest#8343. Documented with comments. Let's see if that did the trick. |
Member
Author
|
Yeay, CI runs 🥳 Codecov is shy for some reason, but it looks good in the dashboard. |
Bibo-Joshi
added
⚙️ security
Bibo-Joshi
added a commit
that referenced
this pull request
Feb 13, 2021
Bibo-Joshi
added
🔌 enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed offline.
Adds requirements-extra called
passport. Installing viapip install ptb[passport]seems more intuitive to me than installing aspip install ptb[crypto]and it's more flexible in terms of which optional dependencies are actually needed for passports.superseeds #2377
closes #2372