-
Notifications
You must be signed in to change notification settings - Fork 5.9k
fix defaults #2363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix defaults #2363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)
|
CI seems to work, finally :) |
# Conflicts: # .github/workflows/test.yml # requirements.txt
Poolitzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic looks fine to me!
Closes #2361
Changes the cryptography requirement to
!=3.4as that release contains a bug with cyclical imports, see pyca/cryptography#5758 .On the fly:
get_updates.read_latency, which apparently got lost somewhere around 2017 according to git blameDefaultValueinstances in signtures in docsdisable_notificationdefault toNoneinstead ofFalse. That has the same effect, we pass less stuff to TG (and it simplified tests)foo = 'text' ' text continued'strings, probably leftovers from switching to black formattingtodo
answer_inline_query