Handle bytes file input #2233
Merged
Handle bytes file input #2233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsnoam
reviewed
Dec 3, 2020
telegram/files/inputfile.py
Outdated
| Args: | ||
| obj (:obj:`File handler`): An open file descriptor. | ||
| obj (:obj:`File handler` | :obj:`bytes`): An open file descriptor. |
Member
There was a problem hiding this comment.
The doc string needs to be adapted.
telegram/files/inputfile.py
Outdated
|
|
||
| @staticmethod | ||
| def is_file(obj: object) -> bool: | ||
| if isinstance(obj, bytes): |
Member
There was a problem hiding this comment.
Well. It's not accurate that it's a file
What are the implications of reverting this change?
Member
Author
There was a problem hiding this comment.
we could make this check in parse_file_input instead. yeah, maybe the cleaner idea.
Member
Author
|
Tested sending files by (relative) local path in linux. Waiting for Pool to test on Windows, then we can merge. |
# Conflicts: # telegram/files/inputmedia.py
# Conflicts: # telegram/files/inputmedia.py
Member
|
Tested sending files by (relative) local path in windows, all good |
Bibo-Joshi
added
🔌 enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2230