Api 5.0 WP 13 (New Filters) #2205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Poolitzer <25934244+Poolitzer@users.noreply.github.com>
Bibo-Joshi
added
🔌 enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some comments:
I ignore pylint complaining about some methods just calling
super. I do that because I think it's important for all of those methods to have a proper docstring. IMO the usage of those filters is complicated enough to justify not just referring to the base class. figuring out what a base class forFilters.{chat, via_bot, user, sender_chat}does is not easy, if you're not familiar with the code.On the fly I updated the example for
XORfilter, as it didn't make any sense :D