Don't call logging.basicConfig() in library code - #22
Merged
Conversation
Logging should be configured by the application, not by libraries it uses. Libraries should just get a logger and log to it. Fixes python-telegram-bot#21
Contributor
|
@leandrotoledo please merge this :) |
leandrotoledo
added a commit
that referenced
this pull request
Aug 8, 2015
Don't call logging.basicConfig() in library code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging should be configured by the application, not by libraries it
uses. Libraries should just get a logger and log to it.
Fixes #21
For another concrete problem caused by calling
logging.basicConfig()in the library,import telegramchanges the meaning of the following program: