Api 5.0 WP 9.5 (Google Place Venues) #2193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poolitzer
reviewed
Nov 29, 2020
Member
Poolitzer
left a comment
Poolitzer
left a comment
There was a problem hiding this comment.
just one question, changes look great
Comment on lines
-44
to
-45
| (For example, "arts_entertainment/default", "arts_entertainment/aquarium" or | ||
| "food/icecream".) |
Member
There was a problem hiding this comment.
hmm I like this actually. Why did you remove it, maintaining?
Member
Author
There was a problem hiding this comment.
Because as a rule of thumb, attribute docstrings should be shorter than the corresponding argument docstring. at least that's what I did up to now …
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBH I didn't try to send
InputVenueMessageContentandILQRVenuewith both foursquare and google place details, but as that doesn't seem to work tosend_venue, I assume it doesn't for those either …