Overhaul constants #2137
Merged
Overhaul constants #2137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bibo-Joshi
requested changes
Oct 12, 2020
Member
Bibo-Joshi
left a comment
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the PR!
A left a few comments. Also in #2104 I mentioned new constants & properties for anonymous admins & servce chat. Could you add those, too? But we can also do that in a spearate PR.
Regarding Codacy: Don't worry about it, I don't know why it complains about the docstrings … maybe
NikitaPirate
changed the title
Bibo-Joshi
requested changes
Oct 12, 2020
Member
Bibo-Joshi
left a comment
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the update :) Just two minor comments left.
PS: You can leave the PR title as is. GH pings me on updates ;)
Bibo-Joshi
approved these changes
Oct 13, 2020
Member
Bibo-Joshi
left a comment
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the contribution :) I'll wait for the tests to run and merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2104