Fix #1297 #1342
Merged
Fix #1297 #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a deepcopy of the user_data and chat_data dict as suggested by @Bibo-Joshi
Member
|
@Eldinnie So we are fine with the performance penalty "issue" as raised by @Bibo-Joshi in #1301 then? |
Member
|
I'm personally fine with it. If people were gonna store massive amounts of data, they would use a proper library/database for it instead I think. |
Member
Author
|
I think we have no choice, and I think the performance penalty will be minimal. Also the fix proposed in #1301 (oops, missed that one before stating on this) means it;s a choice between |
Member
|
CI fail unrelated, will fix on master. |
Eldinnie
added a commit
that referenced
this pull request
Feb 2, 2020
* Update AUTHORS.rst * Update AUTHORS.rst * Add bot_data to CallbackContext as global memory * Minor fixes in docstrings * Incorp. req. changes, Flake8 Fixes * Persist before stop * Fix CI errors * Implement #1342 for bot_data * Add check pickle_persistence_only_bot similar to #1462 * Fix test_persistence * Try dispatching error before logging it * Fix test Co-authored-by: Eldinnie <Eldinnie@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a deepcopy of the user_data and chat_data dict as suggested by @Bibo-Joshi
Fixes #1297