Adjust persistence on exit behaviour #1312
Merged
+43
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
user_dataandchat_datamight be changed between updates (e.g. when storing information from background processes that need to be visible to the user on request), they should be updated before callingflush()on shutdown of the bot. I therefore added the methodupdate_persistence()to theDispatcherclass, that is called from theUpdaterbefore flushing on shutdown.Also, since it will be called on shutdown,
flush()should always flush. I therefore edited the method inPicklePersistenceto be independent ofon_flush.