Clean up else clause on conversation handler check_update for loop #1236 #1240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the for loop does not involve break statements, the else statement is spurious and can be replaced by a default return statement.
As I was reading through this code logic, it took me a while to figure out what the conditional was actually checking. This minor change gives the conditional a name, which for me makes its purpose more explicit.
Member
|
Hi. Thanks for your contribution. It's a duplicate of #1239 but it wil count towards your t-shirt nonetheless :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #1236, this PR replaces the
elseclause on theforloop with a default returnFalsestatement. The unit tests for this class continue to pass. I ran pytest against the whole project and found 2 errors when running locally on my MacBook with Python3.6, but at first glance they appear to be unrelated.I also moved a conditional into a named local variable that to me made the purpose of the block of code that I was changing more explicit.