Skip to content

Fix Filters.regex failing on non-text message #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsmnbom merged 2 commits into from
Aug 26, 2018
Merged

Fix Filters.regex failing on non-text message #1158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51f6729
Fix #1115
Jul 11, 2018
b7c603a
Improve regex filter test
Jul 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion telegram/ext/filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,9 @@ def __init__(self, pattern):
# the matched groups and groupdict to the context object.

def filter(self, message):
return bool(self.pattern.search(message.text))
if message.text:
return bool(self.pattern.search(message.text))
return False

class _Reply(BaseFilter):
name = 'Filters.reply'
Expand Down
3 changes: 3 additions & 0 deletions tests/test_filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ def test_filters_regex(self, message):
message.text = 'i love python'
assert Filters.regex(r'.\b[lo]{2}ve python')(message)

message.text = None
assert not Filters.regex(r'fail')(message)

def test_filters_reply(self, message):
another_message = Message(1, User(1, 'TestOther', False), datetime.datetime.now(),
Chat(0, 'private'))
Expand Down