examples: updated timerbot to work with the latest version of the library #1119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @Mindavi , Thanks for you contribution. You couldn't really know this, but what you actually did was reversing an example. We already merged #1100 in preperation for the V11 release, including the examples. Unfortunately this means the examples won't work with v10.1. Closing this PR because it's actually a rollback. But thanks for noticing and wanting to help. Pieter |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the timerbot example to work with the latest version of the library.
I was working on a bot the other day and found out the example did not work correctly any more.
This pull request should fix that problem.
Perhaps it's also a good idea to have some automated testing for the examples to ensure they won't get out of date?