@jh0ker
number 1 it's the correct solution IMHO, but requires a lot of code and it's not very efficent.
@shouya
the simplest way to update a job is to remove and readd a modified version

to remove a job, number 2 it's simple and works, i tested:
current:

try:
    j.run(self.bot)
except:
    self.logger.exception('An uncaught error was raised while executing job %s' % j.name)
    if j.repeat:
        self.put(j.run, j.interval)

my:

try:
    result = j.run(self.bot)
except:
    self.logger.exception('An uncaught error was raised while executing job %s' % j.name)
    if j.repeat and result:
        self.put(j.run, j.interval)

to stop a job, simply return False from the method. but, this way you lose the option to return a useful value. not a big problem, job doesn't return anything in normal condition, but if you really need to return, you can do something like :

return {'result':'your return value', 'stop_job':True or False}

and

if j.repeat and result['stop_job']:
        self.put(j.run, j.interval)

Other way (TESTED), number 3:
in jobqueue.py

class JobQueue(object):
    def __init__(self, bot, tick_interval=1.0):
        self.tick_interval = tick_interval
        self.queue = PriorityQueue()
        self.bot = bot
        self.logger = logging.getLogger(__name__)
        self.__lock = Lock()
        self.running = False
        self.to_kill = []        #<----new parameter, a list of job name to kill

a new method:

def kill(self, job_name):
        self.to_kill.append(job_name)

a new check before readd the job to the queue

try:
    j.run(self.bot)
except:
    self.logger.exception('An uncaught error was raised while executing job %s' % j.name)
if j.name in self.to_kill:
    self.to_kill.remove(j.name)
    allow = False
else:
    allow = True
if j.repeat and allow:
    self.put(j.run, j.interval)

to kill a job like that:

j = updater.job_queue
j.put(check_database, 100)

simply call:

j.kill('check_database')

in case we can use j.name + str(j.interval) to distinguish different istance of the same process

unable to access job_queue list #280

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions