Fix long description encoding to UTF-8#70
Merged
eigenein merged 1 commit intopython-smpplib:masterfrom Dec 10, 2018
Merged
Conversation
eigenein
approved these changes
Dec 10, 2018
Collaborator
|
Thank you! |
eigenein
reviewed
Dec 10, 2018
| url='https://github.com/podshumok/python-smpplib', | ||
| description='SMPP library for python', | ||
| long_description=open('README.md', 'rt').read(), | ||
| long_description=open('README.md', 'rt', encoding='utf-8').read(), |
Collaborator
There was a problem hiding this comment.
Oops, I was too fast to approve. encoding is indeed missing in Python 2. I'll change it to io.open, if you don't mind.
eigenein
added a commit
that referenced
this pull request
Dec 10, 2018
Follow up to PR #70, fix Python 2.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need this fix for installing in CI.