Skip to content

Refactored Client.send_pdu() #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
code-of-kpp merged 1 commit into from
Apr 15, 2022
Merged

Refactored Client.send_pdu() #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions smpplib/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,22 +207,14 @@ def send_pdu(self, p):
))

self.logger.debug('Sending %s PDU', p.command)

generated = p.generate()

self.logger.debug('>>%s (%d bytes)', binascii.b2a_hex(generated), len(generated))

sent = 0

while sent < len(generated):
try:
sent_last = self._socket.send(generated[sent:])
except socket.error as e:
self.logger.warning(e)
raise exceptions.ConnectionError()
if sent_last == 0:
raise exceptions.ConnectionError()
sent += sent_last
try:
self._socket.sendall(generated)
except socket.error as e:
self.logger.warning(e)
raise exceptions.ConnectionError()

return True

Expand Down