Skip to content

Fix #374: Adapt pyproject.tom for Towncrier#375

Merged
tomschr merged 1 commit into
python-semver:masterfrom
tomschr:bugfix/374-towncrier-config
Nov 26, 2022
Merged

Fix #374: Adapt pyproject.tom for Towncrier#375
tomschr merged 1 commit into
python-semver:masterfrom
tomschr:bugfix/374-towncrier-config

Conversation

@tomschr

@tomschr tomschr commented Nov 26, 2022

Copy link
Copy Markdown
Member

@Nagidal: would you like to review it, please? 🥺

@tomschr tomschr self-assigned this Nov 26, 2022
@tomschr tomschr added the Bug Error, flaw or fault to produce incorrect or unexpected results label Nov 26, 2022

@fleetingbytes fleetingbytes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved

@tomschr tomschr marked this pull request as ready for review November 26, 2022 15:54
* Replace the old, deprecated ``[[tool.towncrier.type]]`` entries
  with ``[tool.towncrier.fragment.<TYPE>]``.
  Described in https://towncrier.readthedocs.io/en/stable/configuration.html#deprecated-defining-custom-fragment-types-with-an-array-of-toml-tables
* Add a changelog news file

Co-authored-by: Nagidal <nagidal@users.noreply.github.com>
@tomschr tomschr force-pushed the bugfix/374-towncrier-config branch from 25e606f to 24e70e9 Compare November 26, 2022 16:04
@tomschr tomschr merged commit 4cf9d60 into python-semver:master Nov 26, 2022
@tomschr tomschr deleted the bugfix/374-towncrier-config branch November 26, 2022 16:08
@tomschr tomschr mentioned this pull request Nov 26, 2022

@fleetingbytes fleetingbytes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be consistent with the Title Case.
We have "Breaking Changes", "Trivial/Internal Changes", so we should have "Improved Documentation", "Bug Fixes".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Error, flaw or fault to produce incorrect or unexpected results

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants