Support matching 'equal' when no operator is provided#362
Support matching 'equal' when no operator is provided#362tomschr merged 3 commits intopython-semver:masterfrom jmi2k:lenient-match
Conversation
|
Hi @jmi2k! Thanks for your contribution, very much appreciated. 👍 🚀 Your implementation looks good, I only have two wishes to complete it:
Many thanks! |
|
First of all, thanks for the in-depth response! I highly appreciate it, as I was kinda lost about how to add that changelog entry. Now I think I have everything in place. The rationale behind this change is that I'm building a plugin dependency system for some in-house tool, and as you will know for sure it's pretty common to specify just the version as an exact dependency. As for now, I've written code around the match to patch the equality operator in when no operator is provided, but I feet like it's more elegant for the library to handle that case too (as the changes required were minimal). If you think I should change anything else, please don't hesitate to tell me! |
|
Thanks @jmi2k, for your additions! Now the PR is complete and I'll merge it to the default branch. Many thanks! In case you find more things to improve, don't hesitate to open an issue or pull request. 🙂 |
This makes it easier to work with user-supplied versions, as they may omit the comparison operator and just specify which version they want to select. Equality comparison is a sane default behavior.