Conversation
tomschr
added
Infra
tomschr
force-pushed
the
feature/176-prepare-py3
branch
from
aa4da51 to
1117551
Compare
tomschr
force-pushed
the
feature/176-prepare-py3
branch
from
fb9e63e to
2a1db1e
Compare
Generally, remove everything related to Python 2.7 & 3.4 and add missing 3.8 & 3.9: * Raise version to 2.99.99 (to indicate that it's different from 2.10.0) * Prepare (empty) CHANGELOG for 2.99.99 * Correct Trove categories and python_requires in setup.py * Adapt tox.ini & .travis.yml: remove old stuff, add missing (see above) * Adapt semver.py - Remove if clause for cmp - Don't check for `__name__`, use `__qualname__` instead - Use yield from ... (for loop is not necessary anymore)
This makes it possible to distinguish between version 2 and version 3. For example, >=2.8,<3
tomschr
force-pushed
the
feature/176-prepare-py3
branch
from
2a1db1e to
77348f7
Compare
|
I may not be an official reviewer, but I am excited about this.
Sounds good to me Since this now supports python >=3.5, it now supports type annotations (on functions only until 3.6). I thought this may be a good moment to start adding type hints to the functions you touch, unless you wanted to type hint everything at once in a single PR. I don't know if it would be the right moment to start thinking about #213 . Anyway, IMHO this is clean and good to go, but that's just me saying that. |
|
@tlaferriere Thanks for your feedback. 👍 It doesn't matter if you are an "official reviewer", everybody is welcome. 😃
Yes, my idea was to introduce this when we "officially" work on version 3 of semver. I have another (local) branch where I did some experiments with it. Or do you think this is something that you would introduce into the semver 2 line? |
Adding type annotations is a breaking change, since python versions prior to 3.5 will give you a hard syntax error for these, so that's a no for including it in the semver 2 line. I would be interested to start type hinting things, I might open a PR tonight (I live in EDT) if I have some spare time. |
|
Thanks for your answer. 👍
Well, it depends. 😉 You can add type annotations into comments with these Of course, for modern Python versions, this is a no-go. For these, we need to use the correct type annotation syntax. |
|
I close this issue in favor of #290; integrated the changes here already in the other PR. |
2 participants
First attempt to prepare for #176
Generally, remove everything related to Python 2.7 & 3.4 and add missing 3.8 & 3.9:
2.99.993.0.0-dev.1tox.ini&.travis.yml: remove old stuff, add missing (see above)semver.py:__name__, use__qualname__insteadyield from ...(for loop is not necessary anymore)@python-semver/reviewers As 2.10.0 is released now, this is the first attempt to keep the ball rolling toward semver 3! 😄
It's a small change, but when merging it to master, we open the development for semver3. All changes will be on top of this.
Question: I used version 3.0.0-dev1 for this, ok?
Let me know what you think about. Thanks.