Fix #244: Allow list & str for comparison - #245
Merged
tomschr merged 1 commit intoMay 5, 2020
Conversation
tomschr
added
the
Bug
tomschr
force-pushed
the
bugfix/244-missing-list-and-str
branch
from
April 26, 2020 21:10
b5bc47a to
f5a0aa4
Compare
The VersionInfo.compare method allows already VersionInfo, dict, tuple/list and str. * Extend list of allowed types in comparator with list and str. * Rewrite case test_should_not_allow_to_compare_version_with_string -> test_should_compare_version_string * Add new test cases: - test_should_compare_version_list - test_should_not_allow_to_compare_invalid_versionstring * Use pytest.mark.parametrize for test_should_compare_version_tuples * Update usage.rst to document all possibilities * Update CHANGELOG
tomschr
force-pushed
the
bugfix/244-missing-list-and-str
branch
from
April 26, 2020 21:15
f5a0aa4 to
7057dc5
Compare
Member
Author
|
@scls19fr any concerns with this PR? If not, I'd merge it on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #244 and contains the following changes:
The
VersionInfo.comparemethod allows alreadyVersionInfo, dict, tuple/list and str.comparatorwith list and str.test_should_not_allow_to_compare_version_with_string->test_should_compare_version_stringtest_should_compare_version_listtest_should_not_allow_to_compare_invalid_versionstringpytest.mark.parametrizefortest_should_compare_version_tuplesusage.rstto document all possibilitiesCHANGELOG