Fix #201: Reformat source code with black#202
Conversation
|
Ahh, the Travis job fails due to "flake8 issues". What should we do with that target? I guess, we should replace it with some "black magic"? 😄 |
tomschr
added
the
Enhancement
|
Actually, seems we don't need "black magic", it can be solved with this addition in [flake8]
max-line-length = 88
exclude =
.env,
.eggs,
.tox,
.git,
__pycache__,
build,
dist |
* Add `pyproject.toml` containing black configuration * Add batch image in `README.rst` * Reformat source code with `black`
Use max-line-length of 88 (default for black)
tomschr
force-pushed
the
feature/201-code-reformat-black
branch
from
f37e9a1 to
437bcd2
Compare
@scls19fr Right, sorry. I've added it in commit 1dc8f9c. |
|
Another question: Should we finish and merge pr #138 first before merging this? I've found an optimized version and posted it in #138 (comment) |
|
I'm fine with either one. 😉 Actually, I was also thinking about the other open pull requests and if we make live of our contributors a bit more difficult. On the other side, some of them are quite old and need to be reviewed (closed, delegated, etc) anyway. |
|
I guess if everyone will run black there should be no conflicts :) |
3 participants
This PR contains the following changes:
pyproject.tomlcontaining black configurationREADME.rstblack(version 19.3b0)Keep in mind,
blackreformats the code quite drastically. That means, all open pull requests will fail to merge. Maybe we should finish and merge pr #138?You will notice, due to #200, the "Check" tab contains now two checks: one for Travis and another one with the GitHub Action for Black. Currently, the black formatting has zero diffs. 👍